feat(server): warning for non web target (#2026)#2104
feat(server): warning for non web target (#2026)#2104Kristonitas wants to merge 4 commits intowebpack:masterfrom
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #2104 +/- ##
==========================================
+ Coverage 94.55% 94.57% +0.01%
==========================================
Files 32 32
Lines 1213 1217 +4
Branches 339 341 +2
==========================================
+ Hits 1147 1151 +4
Misses 64 64
Partials 2 2
Continue to review full report at Codecov.
|
|
@Kristonitas the CLA is not signed, please sign it. if its already signed and still showing not signed, close the PR and reopen it ! |
|
@evilebottnawi |
| if (config.liveReload !== false) { | ||
| log.error(`Live reload won't work with non web target`); | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's use info for this, warn may annoy developers
|
Close in favor #3094, sorry for delay 😞 |
4 participants
For Bugs and Features; did you add new tests?
Modified existing tests inside
addEntries.test.js.Motivation / Use-Case
Help new developers (who check terminal output) to more quickly detect potential misconfiguration when developing a web app while setting
target: "node". A more detailed explanation of this: #2026 (comment). I acknowledge this is something very obvious once you know about the configuration.Breaking Changes
If anyone is doing strict validation of
webpack-dev-serveroutput and using the configuration in question, this might affect them. It should be quite easy to filter/ignore or modify.Additional Info
I made this minimal repo with two scripts to see the different behaviour with
"node"and"web"targets: https://github.com/Kristonitas/live-reload-fail